Code review request: 8006691: Remove jvm_version_info.is_kernel_jvm field

[Mandy Chung]

On 2/8/2013 1:44 PM, Zhengyu Gu wrote:
> Mandy,
>
> Thanks for reviewing.
>
> What's the process to update jvm.h in the jdk repo? it should go to 
> both jdk7 and jdk8, which repos should I make the changes?
>

Like other core-libs development (see the OpenJDK developer guide [1]).

You can work on a clone of http://hg.openjdk.java.net/jdk8/tl/jdk and 
send it out to core-libs-dev at openjdk.java.net for review.  I will 
sponsor the change and push it for you.

There is no rush to update jvm.h in the jdk repo but just to make sure 
the bit can be reused (to avoid out-of-sync definition as jdk 
implementation is using jvm_version_info).  I believe is_kernel_info is 
no longer used in the JDK (I have to dig up the bug number and link it 
to yours).  Please open a new bug for this jdk repo change since they 
will be integrated in different build.

Mandy
[1] http://openjdk.java.net/guide/
> Thanks,
>
> -Zhengyu
>
> On 2/8/2013 4:18 PM, Mandy Chung wrote:
>> Zhengyu,
>>
>> This looks good to me too.   Please also update the jvm.h in the jdk 
>> repo (src/share/javavm/export/jvm.h) - for historical reason, this is 
>> not an exact copy in the hotspot repo and we tend to apply the same 
>> patch rather than replacing it with the hotspot copy.
>>
>> BTW here is the public accessible link to the bug report:
>>     http://bugs.sun.com/view_bug.do?bug_id=8006691
>>
>> Mandy
>>
>> On 2/8/2013 8:00 AM, Zhengyu Gu wrote:
>>> This is a simple change to remove is_kernel_jvm field in 
>>> jvm_version_info structure. The CCC request has been approved, as 
>>> KERNEL VM has been deprecated since JDK7.
>>>
>>> JBS: https://jbs.oracle.com/bugs/browse/JDK-8006691
>>> Webrev: http://cr.openjdk.java.net/~zgu/8006691/webrev.00/
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>>