RFR (XS): 8007901 SA: Don't read flag values as constants

Staffan Larsen staffan.larsen at oracle.com
Mon Feb 11 10:53:19 PST 2013


Yes, you got it right.

Thanks,
/Staffan

On 11 feb 2013, at 19:45, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:

> 
> Nasty, so normally the code picks up the value from the VMIntConstant vmstructs array which is the hardcoded default value, but with this fix it's picked up from the command line options database which reflects the actual current value. That makes sense and looks good.
> 
> Cheers,
> Mikael
> 
> On 2013-02-09 11:06, Staffan Larsen wrote:
>> Please review this small patch to avoid reading flag values in SA as constants. Reading them as constants  means SA will only see the default value for these flags. Instead the infrastructure in SA to read command line flags should be used. In addition the value if EnableInvokeDynamic is never used, so I removed that from SA.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8007901/webrev.00/
>> bug: http://bugs.sun.com/view_bug.do?bug_id=8007901 (not yet visible)
>> 
>> Thanks,
>> /Staffan
> 



More information about the hotspot-dev mailing list