RFR (S): 8008081: Print outs do not have matching arguments
Mikael Vidstedt
mikael.vidstedt at oracle.com
Tue Feb 12 18:27:22 PST 2013
All,
Please review the following change:
http://cr.openjdk.java.net/~mikael/webrevs/8008081/webrev.00/webrev
Background:
I found a few occurrences of calls to print type functions where the
arguments do not match the format string. I hope that I have added the
right/intended arguments in the respective places but could use some
help to verify that that is indeed the case.
One special case is in this webrev is jvmtiEnter.xls. Since it is used
to generate the jvmtiEnterTrace.cpp file and therefore is a bit less
obvious to review I have prepared a pair of before/after files for your
convenience:
Before:
http://cr.openjdk.java.net/~mikael/webrevs/8008081/jvmtiEnterTrace.cpp.orig
After:
http://cr.openjdk.java.net/~mikael/webrevs/8008081/jvmtiEnterTrace.cpp.fixed
I also prepared a diff -u of before vs after:
http://cr.openjdk.java.net/~mikael/webrevs/8008081/jvmtiEnterTrace.cpp.diff
Passes JPRT.
Cheers,
Mikael
More information about the hotspot-dev
mailing list