RFR (S): 8008081: Print outs do not have matching arguments

Staffan Larsen staffan.larsen at oracle.com
Fri Feb 15 00:01:51 PST 2013


src/share/vm/c1/c1_FrameMap.cpp:319
	I wonder if the order of the last two arguments got flipped? Shouldn't the _num_monitors value go inside the [] ?

Otherwise looks good!

/Staffan

On 13 feb 2013, at 03:27, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:

> 
> All,
> 
> Please review the following change:
> 
> http://cr.openjdk.java.net/~mikael/webrevs/8008081/webrev.00/webrev
> 
> Background:
> 
> I found a few occurrences of calls to print type functions where the arguments do not match the format string. I hope that I have added the right/intended arguments in the respective places but could use some help to verify that that is indeed the case.
> 
> One special case is in this webrev is jvmtiEnter.xls. Since it is used to generate the jvmtiEnterTrace.cpp file and therefore is a bit less obvious to review I have prepared a pair of before/after files for your convenience:
> 
> Before: http://cr.openjdk.java.net/~mikael/webrevs/8008081/jvmtiEnterTrace.cpp.orig
> After: http://cr.openjdk.java.net/~mikael/webrevs/8008081/jvmtiEnterTrace.cpp.fixed
> 
> I also prepared a diff -u of before vs after:
> 
> http://cr.openjdk.java.net/~mikael/webrevs/8008081/jvmtiEnterTrace.cpp.diff
> 
> Passes JPRT.
> 
> Cheers,
> Mikael



More information about the hotspot-dev mailing list