Review request for JDK-8007153: update method parameters data in redefineClasses

[Eric McCorkle]

There are other bits in ConstMethod that seem to use CP indexes, and
probably need to be rewritten.

For this, I'm running my usual tests (testlist, ie everything).

For this specific issue, that's a bit difficult, as it involves creating
JAR files and running the vm with very specific arguments (which took me
a while to figure out).  I'm pretty sure this is beyond what JPRT can do.

I don't really know anything about hotspot's test suites, so someone
else will have to answer there.

On 02/18/13 10:21, Coleen Phillimore wrote:
> 
> Eric,
> This looks good.
> I should have changed rewrite_cp_refs_in_methods_annotations and the
> other two to be called from rewrite_cp_refs_in_method() like you did.  
> Are type_annotations also constant pool references?   Should they be
> rewritten too?   Is there a test for this?
> 
> Thanks,
> Coleen
> 
> On 02/18/2013 10:03 AM, Eric McCorkle wrote:
>> Hello,
>>
>> Please review this simple patch which updates hotspot to correctly
>> manage method parameter data when redefineClasses is called.
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~emc/8007153/
>