RFR (S): 8006965: test_gamma should run with import JDK

[Christian Thalinger]

On Feb 22, 2013, at 11:39 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> On 2/22/13 11:04 AM, Christian Thalinger wrote:
>> 
>> On Feb 22, 2013, at 9:29 AM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
>> 
>>> On 2013-02-22 08:48, Christian Thalinger wrote:
>>>> On Feb 22, 2013, at 12:58 AM, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>>> 
>>>>> I'm not sure what the correct solution is, but when you do find out, the jdkpath.sh target should also be updated.
>>>> That file is in the JDK I suppose?  -- Chris
>>> 
>>> The jdkpath.sh file is generated as part of building hotspot, see buildtree.make in the various OS specific make directories.
>> 
>> Oh.  The other script.  What is actually env.csh used for?  Or .dbxrc?  Anyone using these files?
> 
> They are used for incremental build and debugging using gamma:
> 
> "cd solaris_amd64_compiler2/jvmg; gnumake; dbx gamma"
> 
> I work this way.

But DBX picks up your ~/.dbxrc by default anyway and the file only contains:

$ cat .dbxrc 
echo '# Loading solaris_amd64_graal/product/.dbxrc'
if [ -f "${HOTSPOT_DBXWARE}" ]
then
        source "${HOTSPOT_DBXWARE}"
elif [ -f "$HOME/.dbxrc" ]
then
        source "$HOME/.dbxrc"
fi

The question is what is/was HOTSPOT_DBXWARE?

-- Chris

> 
> Vladimir
> 
>> 
>> -- Chris
>> 
>>> 
>>> Cheers,
>>> Mikael
>>> 
>>>> 
>>>>> Thanks,
>>>>> /Staffan
>>>>> 
>>>>> On 22 feb 2013, at 03:40, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>>> 
>>>>>> http://cr.openjdk.java.net/~twisti/8006965
>>>>>> 
>>>>>> 8006965: test_gamma should run with import JDK
>>>>>> Reviewed-by:
>>>>>> 
>>>>>> Right now test_gamma runs with the boot JDK which is JDK n-1 (where
>>>>>> JDK n is the version we are actually compiling for).  This setup is
>>>>>> unsupported and thus should not be done during HotSpot builds.
>>>>>> 
>>>>>> The fix is to always use JDK_IMPORT_PATH instead of JAVA_HOME when
>>>>>> running test_gamma.
>>>>>> 
>>>>>> make/bsd/makefiles/buildtree.make
>>>>>> make/defs.make
>>>>>> make/linux/makefiles/buildtree.make
>>>>>> make/solaris/makefiles/buildtree.make
>>> 
>>