RFR (S): 8006965: test_gamma should run with import JDK

[BILL PITTORE]

On 2/22/2013 7:39 PM, Coleen Phillimore wrote:
> On 2/22/2013 6:21 PM, Christian Thalinger wrote:
>> On Feb 22, 2013, at 12:58 AM, Staffan Larsen 
>> <staffan.larsen at oracle.com> wrote:
>>
>>> I'm not sure what the correct solution is, but when you do find out, 
>>> the jdkpath.sh target should also be updated.
>> How many are actually using the hotspot script?  Would people be very 
>> sentimental if we would remove the gamma launcher altogether?
>>
>> Taking to people here it seems that most are copying their libjvm 
>> into a JDK and use java anyway.
>
> I use the hotspot script on linux to debug with -gdb, ie:
>
> hotspot -gdb <command line arguments>
>
> It works really well!  So the gamma launcher is really good for 
> debugging without having to do odd things like ^C or PauseVMAtStartup 
> to set breakpoints after libjvm.so is loaded. How else can you debug 
> this?
With recent versions of gdb I have no problem debugging using gdb on the 
java executable
gdb --args ./bin/java -cp . HelloWorld
GNU gdb (Ubuntu/Linaro 7.4-2012.04-0ubuntu2) 7.4-2012.04
...
(gdb) break ClassVerifier::verify_method
Make breakpoint pending on future shared library load? (y or [n]) y

Breakpoint 1 (ClassVerifier::verify_method) pending.
(gdb) run
...

Breakpoint 1, ClassVerifier::verify_method (this=0xf732ab60, m=0xf732ab08,
     __the_thread__=0xf7108000)
     at 
/export/users/bpittore/hotspot-emb/hotspot/src/share/vm/classfile/verifier.cpp:575
575      HandleMark hm(THREAD);
(gdb)

bill
>
> For testing, I copy the jvm into a jdk binary.
>
> Coleen
>>
>> -- Chris
>>
>>> Thanks,
>>> /Staffan
>>>
>>> On 22 feb 2013, at 03:40, Christian Thalinger 
>>> <christian.thalinger at oracle.com> wrote:
>>>
>>>> http://cr.openjdk.java.net/~twisti/8006965
>>>>
>>>> 8006965: test_gamma should run with import JDK
>>>> Reviewed-by:
>>>>
>>>> Right now test_gamma runs with the boot JDK which is JDK n-1 (where
>>>> JDK n is the version we are actually compiling for).  This setup is
>>>> unsupported and thus should not be done during HotSpot builds.
>>>>
>>>> The fix is to always use JDK_IMPORT_PATH instead of JAVA_HOME when
>>>> running test_gamma.
>>>>
>>>> make/bsd/makefiles/buildtree.make
>>>> make/defs.make
>>>> make/linux/makefiles/buildtree.make
>>>> make/solaris/makefiles/buildtree.make
>>>>
>