Request for review: JDK-8004728 Hotspot support for parameter reflection

[Karen Kinnear]

Eric,

Code looks good. Thank you for running the testlist. What platform did you run it on?

Also - I assume that the unit test will be checked in with the reflection library code
change. 

So the two remaining issues are:
1) how does this work with class redefinition?
2) how does this work serviceability agent?
  - see agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java for where to add fixes

Please  file additional bugs for those to fix for jdk8.

It is ok to  check this is in  prior to
fixing those because of the need to get this initial hotspot set of changes in to
be able to get the core library changes in which depend on these. In general it
is important to get all of the dependent functionality working before checking any of it in.


Questions/comments:

1. test/Makefile
Is there a reason you changed the jtreg version? Did someone ask you to?
To do this you want to rerun all the jtreg tests :-) - or you could skip this change

2. constMethod.cpp/constMethod.hpp

I realize that this is complex, and it would be good to file an rfe to make this less
brittle and sync up with serviceability agent better.

In the meantime, thank you for the improved comments and fix to the
generic_signature_index 
Thank you for the comments in ConstMethod::set_inlined_tables_length.
Could you possibly add a comment that  serviceability agent knows about the actual ordering
and needs to be changed if any fields are added here?

3. vmSynbols.hpp
Please check spacing for line 89

thanks,
Karen

On Jan 4, 2013, at 9:14 PM, Eric McCorkle wrote:

> Hello,
> 
> Please review the following change set, which implements support for method parameter reflection in hotspot.  The open webrev can be found here:
> 
> http://cr.openjdk.java.net/~acorn/8004728/webrev
> 
> The feature request can be found here
> 
> http://bugs.sun.com/view_bug.do?bug_id=8004728
> 
> The latest version of the spec can be found here:
> 
> http://cr.openjdk.java.net/~abuckley/8misc.pdf
> 
> 
> This has been posted to the list before, but it has since undergone testing and revision.
> 
> I have run testlist (which runs *all* tests), and seen no new failures.  Additionally, I have run several clean JPRT runs.
> 
> Thanks,
> Eric