Round 4: Code review request: JDK-8005048, NMT: #loaded classes needs to just show the # defined classes

[Karen Kinnear]

Zhengyu,

Looks good. Thanks for fixing this.

Karen

On Jan 4, 2013, at 11:24 AM, Zhengyu Gu wrote:

> Previous fix could cause instance class counter go negative, since class list in ClassLoaderData contains none instance classes, and walking the list is not desirable.
> 
> The new solution is to decrement counter in InstanceKlass::release_C_heap_structures.
> 
> http://cr.openjdk.java.net/~zgu/8005048/webrev.03/
> 
> Thanks,
> 
> -Zhengyu
> 
> On 12/17/2012 3:11 PM, Zhengyu Gu wrote:
>> Current NMT implementation reports number of loaded classes at query time, but number of defined classes is what is expected.
>> 
>> This changset reflects two major changes:
>> 
>> 1. It counts number of defined classes vs. number of loaded classes
>> 2. It counts number of defined classes for each generation, vs. counts at query time. In this way, the number of defined classes that NMT reports, should match the corresponding class metadata data. As the result, the data should be more accurate.
>> 
>> 
>> Webrev: http://cr.openjdk.java.net/~zgu/8005048/webrev.00/
>> 
>> 
>> Thanks,
>> 
>> -Zhengyu