Code review request: 7152671, RFE: Windows decoder should add some std dirs to the symbol search path

[Daniel D. Daugherty]

On 1/8/13 2:44 PM, Kelly O'Hair wrote:
> You are modifying the search path (PATH?) for the VM process?

Kelly,

This code should be modifying the SymbolSearchPath:

     _pfn_SymSetSearchPath(hProcess, paths);

Zhengyu,

I'm reviewing this code now.

Dan

> Doesn't that impact the entire process?
> And doesn't it impact more than just pdb files being found?
>
> Sorry for sticking my nose in here, but something tells me this needs a wider review than just the hotspot team.
>
> -kto
>
> On Jan 8, 2013, at 12:34 PM, Zhengyu Gu wrote:
>
>> This is an enhancement that allows Windows decoder to search pdb files that are created by FDS.
>>
>> In short, if FDS pdb files are downloaded into following paths, Widnows decoder should be able to use them to decode stacks:
>>
>> $JDK/lib
>> $JRE/lib
>> directory where jvm.dll is loaded from.  ($JRE/bin/{server or client})
>>
>>
>> http://cr.openjdk.java.net/~zgu/7152671/webrev.01/
>>
>>
>> Thanks,
>>
>> -Zhengyu
>>
>
>