Code review request: 7152671,RFE: Windows decoder should add some std dirs to the symbol search path

[Zhengyu Gu]

Yes. Fixed based on Staffan's comment.

Thanks again.

-Zhengyu

On 1/9/2013 11:14 AM, Daniel D. Daugherty wrote:
> line 134: // replaced 'jre' with 'lib'
>     More precisely, the "lib" should now say "bin".
>
> Dan
>
>
> On 1/9/13 9:04 AM, Staffan Larsen wrote:
>> Comment on line 134 says "jre", but should now say "bin".
>>
>> Thanks,
>> /Staffan
>>
>> On 9 jan 2013, at 16:43, Zhengyu Gu <zhengyu.gu at oracle.com> wrote:
>>
>>> I updated webrev to reflect the comments from Dan and Christian. 
>>> Also, I updated the bug report to correct search paths to
>>>
>>>      $JAVA_HOME/bin
>>>      $JAVA_HOME/jre/bin
>>>      $JAVA_HOME/jre/bin/{client or server}
>>>
>>>
>>> http://cr.openjdk.java.net/~zgu/7152671/webrev.02/
>>>
>>> Please review.
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>> On 1/9/2013 9:43 AM, Daniel D. Daugherty wrote:
>>>> On 1/9/13 7:17 AM, Zhengyu Gu wrote:
>>>>> Good question.
>>>> Good catch Christian!
>>>>
>>>>
>>>>> Dan, do you have any comments?
>>>> Yes. I keep forgetting that Windows keeps libraries in the "bin"
>>>> directory rather than in a "lib" directory like a "normal" system. :-)
>>>> So when I filed the bug, I wrote:
>>>>
>>>>> The Windows decoder should add the following directories to the
>>>>> symbol search path:
>>>>>
>>>>>      $JAVA_HOME/lib
>>>>>      $JAVA_HOME/jre/lib
>>>>>      $JAVA_HOME/jre/bin/client
>>>>>      $JAVA_HOME/jre/bin/server
>>>> In the above list, both "lib" names should be "bin".
>>>>
>>>> Dan
>>>>
>>>>> Thanks,
>>>>>
>>>>> -Zhengyu
>>>>>
>>>>>
>>>>> On 1/9/2013 3:02 AM, Christian Törnqvist wrote:
>>>>>> Hi Zhengyu,
>>>>>>
>>>>>> Why do we need to add JDK/lib and JRE/lib to the symbol path? 
>>>>>> Looking at where the symbols are I would expect the symbol path 
>>>>>> to include the jvm.dll directory and JRE/bin ?
>>>>>>
>>>>>> Thanks,
>>>>>> Christian
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Zhengyu Gu
>>>>>> Sent: den 8 januari 2013 21:35
>>>>>> To: hotspot-dev at openjdk.java.net
>>>>>> Subject: Code review request: 7152671,RFE: Windows decoder should 
>>>>>> add some std dirs to the symbol search path
>>>>>>
>>>>>> This is an enhancement that allows Windows decoder to search pdb 
>>>>>> files that are created by FDS.
>>>>>>
>>>>>> In short, if FDS pdb files are downloaded into following paths, 
>>>>>> Widnows decoder should be able to use them to decode stacks:
>>>>>>
>>>>>> $JDK/lib
>>>>>> $JRE/lib
>>>>>> directory where jvm.dll is loaded from.  ($JRE/bin/{server or 
>>>>>> client})
>>>>>>
>>>>>>
>>>>>> http://cr.openjdk.java.net/~zgu/7152671/webrev.01/
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -Zhengyu
>>>>>>
>