RFR: 8005467 CDS size information

Christian Thalinger christian.thalinger at oracle.com
Wed Jan 9 12:20:37 PST 2013


On Jan 9, 2013, at 10:15 AM, Ioi Lam <ioi.lam at oracle.com> wrote:

> Please review:
> 
> http://cr.openjdk.java.net/~coleenp/8005467_cds_size_info_002/
> 
> bug: CDS size information is incorrect and unfriendly
> https://jbs.oracle.com/bugs/browse/JDK-8005467
> 
> 
> Summary:
> 
> The printed size information is changed from
> 
>  ro space: 0x000000000014718a out of 0x0000000000200000 words allocated at 0x0000000080000000.
>  rw space: 0x000000000017a6ac out of 0x0000000000200000 words allocated at 0x0000000081000000.
>  md space: 0x0000000000241a70 out of 0x0000000000400000 words allocated at 0x0000000082000000.
>  mc space: 0x0000000000008505 out of 0x000000000001e000 words allocated at 0x0000000082400000.
> 
> to
> 
>  ro space:   8287312 [39.1% total] out of  16777216 bytes [49.4% full] at 0x0000000080000000.
>  rw space:  11369872 [53.7% total] out of  16777216 bytes [67.8% full] at 0x0000000081000000.
>  md space:   1487248 [ 7.0% total] out of   4194304 bytes [35.5% full] at 0x0000000082000000.
>  mc space:     34053 [ 0.2% total] out of    122880 bytes [27.7% full] at 0x0000000082400000.

The "% total" and "% full" are confusing.  Should this be "% of total"?

>  total   :  21178485 bytes

This is "total usage", I suppose.  Could we also print "total allocated size"?

-- Chris

> 
> There is otherwise no functional change.
> 
> 
> Tests run:
> 
> + JPRT -- to verify build-ability
> 
> + Manually ran java -Xshare:dump on Linux/Solaris/MacOS/Windows7
>  (32- and 64-bit VM) to verify the printed output is as expected.
> 
> Thanks,
> Ioi
> 



More information about the hotspot-dev mailing list