Request for review: Unify SERIALGC and INCLUDE_ALTERNATE_GCS

[Bengt Rutisson]

Hi Joe,

Thanks for fixing this! I think it looks much better with 
INCLUDE_ALL_GCS in the code than SERIALGC.

I think the changes look good, but we need to set up INCLUDE_ALL_GCS in 
the make files and not just in macros.hpp. There is nothing that 
requires source files to include marcros.hpp. If that include is missing 
and the source file contains a statement like:

#if INCLUDE_ALL_GCS

the value of INCLUDE_ALL_GCS will be interpreted as 0 and we will not 
get a compilation error. So, it is not enough to set INCLUDE_ALL_GCS to 
0 in excludeSrc.make. We also need to set it to 1 for the default case.


Also, just a reminder to inform Kelly about this change. I know that he 
has been asking everyone who updates make files to let him know about it 
to make sure that there are not conflicts with the build system changes.

Thanks,
Bengt

On 1/9/13 8:48 PM, Joe Provino wrote:
> INCLUDE_ALTERNATE_GCS has been changed to INCLUDE_ALL_GCS.
>
> SERIALGC has been removed and INCLUDE_ALL_GCS is used instead.
>
> The webrev is here: 
> http://cr.openjdk.java.net/~jprovino/8005915/webrev.00
>
> Thanks.
>
> joe