RFR (M) #5 CR 8003985: Support @Contended annotation

Aleksey Shipilev aleksey.shipilev at oracle.com
Thu Jan 10 15:20:09 PST 2013


Thanks Jesper!

On 01/11/2013 03:15 AM, Jesper Wilhelmsson wrote:
> I have looked through the change and I don't see anything obviously
> wrong with it, but this change is in a part of HotSpot that I don't know
> at all so I wouldn't count this as a review.
> 
> You are adding a TODO in classFileParser.cpp , is that intentional?

Yes, we would need to follow up on that once we have more usages, which
will allow us to experiment more thoroughly on this.

> I have followed the discussions around @contended over the last year and
> I feel comfortable sponsoring this change once it has been approved by
> proper reviewers.

Good. The code was not changed since last review; the only culprit was
pending CCC, and now it is approved. I think Vladimir, John, and Coleen
were OK. Guys, can you confirm you still OK?

-Aleksey.


More information about the hotspot-dev mailing list