RFR: 8005467 CDS size information

[Ioi Lam]

Hi,

I have updated the patch to use the formats suggested by Coleen and 
Christian:

http://cr.openjdk.java.net/~coleenp/8005467_cdc_size_info_003/

Now it looks like:

    ro space:   8687488 [ 40.3% of total] out of 16777216 bytes [51.8%
    used] at 0x0000000080000000
    rw space:  11369872 [ 52.7% of total] out of  16777216 bytes [67.8%
    used] at 0x0000000081000000
    md space:   1487320 [  6.9% of total] out of   4194304 bytes [35.5%
    used] at 0x0000000082000000
    mc space:     34053 [  0.2% of total] out of    122880 bytes [27.7%
    used] at 0x0000000082400000
    total   :  21578733 [100.0% of total] out of  37871616 bytes [57.0%
    used]

Thanks
- Ioi

On 01/09/2013 05:07 PM, Coleen Phillimore wrote:
>
> How about "used"?   GC uses "used" for such things.
>
> ro space:   8287312 [39.1% total] out of  16777216 bytes [49.4% full] 
> at 0x0000000080000000.
>
> Thanks,
> Coleen
>
> On 1/9/2013 5:29 PM, Christian Thalinger wrote:
>> On Jan 9, 2013, at 12:52 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
>>
>>> On 01/09/2013 12:20 PM, Christian Thalinger wrote:
>>>> On Jan 9, 2013, at 10:15 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
>>>>
>>>>> Please review:
>>>>>
>>>>> http://cr.openjdk.java.net/~coleenp/8005467_cds_size_info_002/
>>>>>
>>>>> bug: CDS size information is incorrect and unfriendly
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8005467
>>>>>
>>>>>
>>>>> Summary:
>>>>>
>>>>> The printed size information is changed from
>>>>>
>>>>>   ro space: 0x000000000014718a out of 0x0000000000200000 words 
>>>>> allocated at 0x0000000080000000.
>>>>>   rw space: 0x000000000017a6ac out of 0x0000000000200000 words 
>>>>> allocated at 0x0000000081000000.
>>>>>   md space: 0x0000000000241a70 out of 0x0000000000400000 words 
>>>>> allocated at 0x0000000082000000.
>>>>>   mc space: 0x0000000000008505 out of 0x000000000001e000 words 
>>>>> allocated at 0x0000000082400000.
>>>>>
>>>>> to
>>>>>
>>>>>   ro space:   8287312 [39.1% total] out of  16777216 bytes [49.4% 
>>>>> full] at 0x0000000080000000.
>>>>>   rw space:  11369872 [53.7% total] out of  16777216 bytes [67.8% 
>>>>> full] at 0x0000000081000000.
>>>>>   md space:   1487248 [ 7.0% total] out of   4194304 bytes [35.5% 
>>>>> full] at 0x0000000082000000.
>>>>>   mc space:     34053 [ 0.2% total] out of    122880 bytes [27.7% 
>>>>> full] at 0x0000000082400000.
>>>> The "% total" and "% full" are confusing.  Should this be "% of 
>>>> total"?
>>>>
>>>>>   total   :  21178485 bytes
>>>> This is "total usage", I suppose.  Could we also print "total 
>>>> allocated size"?
>>> Hi Chris,
>>>
>>> Thanks for the review. Would this be clearer?
>>>
>>> ro space:   8287312 [ 39.1% of total] out of  16777216 bytes [49.4% 
>>> occupied] at 0x0000000080000000
>>> rw space:  11369872 [ 53.7% of total] out of  16777216 bytes [67.8% 
>>> occupied] at 0x0000000081000000
>>> md space:   1487248 [  7.0% of total] out of   4194304 bytes [35.5% 
>>> occupied] at 0x0000000082000000
>>> mc space:     34053 [  0.2% of total] out of    122880 bytes [27.7% 
>>> occupied] at 0x0000000082400000
>>> total   :  21178485 [100.0% of total] out of  37871616 bytes [55.9% 
>>> occupied]
>> Much better.  Thanks.  -- Chris
>>
>>>
>>> Thanks
>>> - Ioi
>>>
>>>> -- Chris
>>>>
>>>>> There is otherwise no functional change.
>>>>>
>>>>>
>>>>> Tests run:
>>>>>
>>>>> + JPRT -- to verify build-ability
>>>>>
>>>>> + Manually ran java -Xshare:dump on Linux/Solaris/MacOS/Windows7
>>>>>   (32- and 64-bit VM) to verify the printed output is as expected.
>>>>>
>>>>> Thanks,
>>>>> Ioi
>>>>>
>