Code review request: 8005936, PrintNMTStatistics doesn't work for normal JVM exit

Karen Kinnear karen.kinnear at oracle.com
Fri Jan 11 05:15:08 PST 2013


Good catch David.

Zhengyu - looks like you could put this right after the call to print_statistics in before_exit in java.cpp.

thanks,
KAren

On Jan 11, 2013, at 12:04 AM, David Holmes wrote:

> On 11/01/2013 6:57 AM, Zhengyu Gu wrote:
>> Moved NMT shutdown code to JVM exit handler, so guarantees that NMT
>> memory statistics can be reported when PrintNMTStatistics flag is enabled.
>> 
>> webrev: http://cr.openjdk.java.net/~zgu/8005936/webrev.00/
> 
> print_statistics() seems the wrong place to put the shutdown code. Plus you only added it to the non-product path.
> 
> David
> 
>> Tests:
>> 
>> 1. JPRT tests
>> 2. UTE vm.quick.testlist on Windows x64, Solaris sparv9, Linux x32 and x64
>> 
>> 
>> Thanks,
>> 
>> -Zhengyu



More information about the hotspot-dev mailing list