RFR (M) #5 CR 8003985: Support @Contended annotation

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jan 11 16:22:46 PST 2013


 > Vladimir, are you suggesting that I push directly to hotspot-main? - all
 > of it or just the jdk stuff?
 > /Jesper


Only jdk changes, Hotspot changes should go into group's repo. Don't 
forget to add Contributed-by into changeset's comment.

I will do JDK push. I will create Sub-Task rfe, as Joe suggested, for 
jdk changes so we can track them separately.

Thanks,
Vladimir

On 1/11/13 4:02 PM, Jesper Wilhelmsson wrote:
> On 12/1/13 12:47 AM, Aleksey Shipilev wrote:
>> On 01/12/2013 03:40 AM, Vladimir Kozlov wrote:
>>> On 1/11/13 3:11 PM, Aleksey Shipilev wrote:
>>>> On 01/12/2013 02:10 AM, Vladimir Kozlov wrote:
>>>>> I mentioned this because for previous your changes "8004330: Add
>>>>> missing
>>>>> Unsafe entry points" I had to do it for you. You should make life of
>>>>> your sponsor better and not worse, we have a lot of other things to
>>>>> do.
>>>> OK, sounds fair. I wish you had this explanation in 8004330
>>>> timeframe. I
>>>> was under the false impression this is how we do the coordinated
>>>> HotSpot-JDK change.
>>> We (VM group) can push jdk changes again using hotspot-main/jdk repo as
>>> with 8004330 to synchronize push.
>> Ok, that was my impression as well.
>
> Aleksey, If I understand this correctly you don't need a separate
> sponsor for the jdk changes (you asked for a sponsor in the jdk webrev).
>
> Vladimir, are you suggesting that I push directly to hotspot-main? - all
> of it or just the jdk stuff?
> /Jesper
>
>>
>>> I just want a separate webrev for lib changes to let lib guys know what
>>> is coming to them.
>> Ok.
>>
>>> Also VM push process (JPRT) does not do automatic push into jdk code
>>> together with VM changes - it is 2 different jobs. So we have to
>>> separate Hotspot and JDK changes.
>> :(
>>
>>>>     http://cr.openjdk.java.net/~shade/8003985/webrev.vm.02/
>>> This looks better. Please, fix copyright year in Contended.java
>> Ah, I submitted the fixed year for JDK reviews. Fixed in VM webrev as
>> well now.
>>
>> -Aleksey.
>


More information about the hotspot-dev mailing list