Code review request: 8005936, PrintNMTStatistics doesn't work for normal JVM exit

[Zhengyu Gu]

As mentioned in comment, NMT has to be shutdown before VM exit, so I think it is the place as function name suggested.


-Zhengyu


Sent from my iPhone

On Jan 13, 2013, at 7:25 PM, David Holmes <david.holmes at oracle.com> wrote:

> On 12/01/2013 1:18 AM, Zhengyu Gu wrote:
>> Thanks, David.
>> 
>> My bad, I do mean JVM exit handler, but rushed ...
>> Here is updated webrev:
>> 
>> http://cr.openjdk.java.net/~zgu/8005936/webrev.01/
> 
> Why put it at the end of before_exit instead of just putting it after the call to before_exit ?
> 
> David
> 
>> Thanks,
>> 
>> -Zhengyu
>> 
>> On 1/11/2013 12:04 AM, David Holmes wrote:
>>> On 11/01/2013 6:57 AM, Zhengyu Gu wrote:
>>>> Moved NMT shutdown code to JVM exit handler, so guarantees that NMT
>>>> memory statistics can be reported when PrintNMTStatistics flag is
>>>> enabled.
>>>> 
>>>> webrev: http://cr.openjdk.java.net/~zgu/8005936/webrev.00/
>>> 
>>> print_statistics() seems the wrong place to put the shutdown code.
>>> Plus you only added it to the non-product path.
>>> 
>>> David
>>> 
>>>> Tests:
>>>> 
>>>> 1. JPRT tests
>>>> 2. UTE vm.quick.testlist on Windows x64, Solaris sparv9, Linux x32
>>>> and x64
>>>> 
>>>> 
>>>> Thanks,
>>>> 
>>>> -Zhengyu