RFR (M) #5 CR 8003985: Support @Contended annotation

[Staffan Larsen]

On 15 jan 2013, at 19:52, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> Sorry to hear it. Looking.
> Is this a part of regular test suite (which I had missed to run)?

No, there are precious few tests for SA (working on adding them). I happened to run into it when looking for something else.

/Staffan

> 
> -Aleksey.
> 
> On 01/15/2013 10:43 PM, Staffan Larsen wrote:
>> This change seems to have broken deadlock detection in SA. Here is the exception that I get:
>> 
>> java.lang.RuntimeException: should not reach here
>>        at sun.jvm.hotspot.oops.InstanceKlass.getFieldOffset(InstanceKlass.java:327)
>> 
>> I haven't yet dug into the details. To reproduce, start any Java program, then run:
>> 
>>> sudo build/linux/linux_amd64_compiler2/jvmg/hotspot -cp build/linux/linux_amd64_compiler2/generated/sa-jdi.jar sun.jvm.hotspot.tools.JStack <pid of the program>
>> 
>> Using java runtime at: /home/staffan/java/8latest/jre
>> Attaching to process ID 28487, please wait...
>> Debugger attached successfully.
>> Server compiler detected.
>> JVM version is 25.0-b15-internal-jvmg
>> Deadlock Detection:
>> 
>> java.lang.RuntimeException: should not reach here
>>        at sun.jvm.hotspot.oops.InstanceKlass.getFieldOffset(InstanceKlass.java:327)
>>        at sun.jvm.hotspot.oops.Field.<init>(Field.java:47)
>>        at sun.jvm.hotspot.oops.OopField.<init>(OopField.java:42)
>>        at sun.jvm.hotspot.oops.InstanceKlass.newField(InstanceKlass.java:915)
>>        at sun.jvm.hotspot.oops.InstanceKlass.findLocalField(InstanceKlass.java:628)
>>        at sun.jvm.hotspot.oops.InstanceKlass.findField(InstanceKlass.java:665)
>>        at sun.jvm.hotspot.oops.InstanceKlass.findField(InstanceKlass.java:689)
>>        at sun.jvm.hotspot.oops.OopUtilities.initThreadFields(OopUtilities.java:220)
>>        at sun.jvm.hotspot.oops.OopUtilities.threadOopGetParkBlocker(OopUtilities.java:292)
>>        at sun.jvm.hotspot.runtime.JavaThread.getCurrentParkBlocker(JavaThread.java:385)
>>        at sun.jvm.hotspot.runtime.DeadlockDetector.print(DeadlockDetector.java:82)
>>        at sun.jvm.hotspot.runtime.DeadlockDetector.print(DeadlockDetector.java:39)
>>        at sun.jvm.hotspot.tools.StackTrace.run(StackTrace.java:52)
>>        at sun.jvm.hotspot.tools.StackTrace.run(StackTrace.java:45)
>>        at sun.jvm.hotspot.tools.JStack.run(JStack.java:60)
>>        at sun.jvm.hotspot.tools.Tool.start(Tool.java:221)
>>        at sun.jvm.hotspot.tools.JStack.main(JStack.java:86)
>> Can't print deadlocks:should not reach here
>