RFR (XS) CR 8006403: Regression: jstack failed due to the FieldInfo regression in SA
David Holmes
david.holmes at oracle.com
Wed Jan 16 05:07:08 PST 2013
Me too. (Reviewer) :)
Thanks,
David
On 16/01/2013 8:03 PM, Staffan Larsen wrote:
> Looks good to me (not a Reviewer).
>
> Thanks,
> /Staffan
>
> On 16 jan 2013, at 10:49, Aleksey Shipilev<aleksey.shipilev at oracle.com> wrote:
>
>> On 01/16/2013 01:45 PM, Staffan Larsen wrote:
>>> Thanks for jumping on this.
>>
>> That's my sin to write that dumb code in the first place.
>>
>>> Shouldn't this be looked up the same way the other constants are looked up? Something like:
>>>
>>> FIELDINFO_TAG_MASK = db.lookupIntConstant("FIELDINFO_TAG_MASK").shortValue();
>>
>> Yes, that occurred to me as well, see updated webrev:
>> http://cr.openjdk.java.net/~shade/8006403/webrev.02/
>>
>> Tested that jstack now works fine.
>>
>> -Aleksey.
>
More information about the hotspot-dev
mailing list