RFR (S): 8006413: Add utility classes for writing better multiprocess tests in jtreg

[Christian Törnqvist]

Hi Vitaly,

 

Setting them as daemon sounds like a good idea :)

 

I'd like your feedback on the other things as well, the quality of test code is important.

 

Thanks,

Christian

 

From: Vitaly Davidovich [mailto:vitalyd at gmail.com] 
Sent: den 16 januari 2013 14:50
To: Christian Törnqvist
Cc: hotspot-dev at openjdk.java.net
Subject: Re: RFR (S): 8006413: Add utility classes for writing better multiprocess tests in jtreg

 

Hi Christian,

Not sure how polished you want/need this code to be since it's just utility, but one thing that jumped out was the stream pumper threads for reading stdout/err should be daemonized just to play it safe.

There are some other things that can be done, but not sure it's worth the effort for a testing utility.  Let me know though if you'd like to cover everything.

Thanks

Sent from my phone

On Jan 16, 2013 7:36 AM, "Christian Törnqvist" <HYPERLINK "mailto:christian.tornqvist at oracle.com"christian.tornqvist at oracle.com> wrote:

Hi everyone,

 

This RFE adds a few utility classes to make it a bit easier to write multi-process tests in jtreg, webrev can be found at http://cr.openjdk.java.net/~brutisso/8006413/webrev.00/

 

Thanks,

Christian