RFR (S): 8006413: Add utility classes for writing better multiprocess tests in jtreg

Nils Loodin nils.loodin at oracle.com
Wed Jan 16 06:56:24 PST 2013


Looks nice! Apart from Vitalys feedback, a few nits:

JDKToolFinder.java, OutputAnalyzer : javadoc? Had some in 
ProcessTools.java, it looked nice :)

OutputAnalyzer: single character variable names

ProcessTools.java:84 Javadoc should probably describe intent, not the 
current hack-implementation ;)
(that could perhaps be mentioned in a comment in the method

StreamPumper.java:34,34
Variable name sin and sout isn't pretty perhaps, since they're mentioned 
in the javadoc for the run()-method.

Regards,
Nils Loodin

On 01/16/2013 01:34 PM, Christian Törnqvist wrote:
> Hi everyone,
>
>   
>
> This RFE adds a few utility classes to make it a bit easier to write multi-process tests in jtreg, webrev can be found at http://cr.openjdk.java.net/~brutisso/8006413/webrev.00/
>
>   
>
> Thanks,
>
> Christian



More information about the hotspot-dev mailing list