RFR (XS) CR 8006403: Regression: jstack failed due to the FieldInfo regression in SA
Aleksey Shipilev
aleksey.shipilev at oracle.com
Wed Jan 16 09:33:50 PST 2013
I think Staffan had already submitted the JPRT job to integrate.
-Aleksey.
On 16.01.2013, at 21:26, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
> OK, since these changes are in hotspot I'll sponsor this change as well.
> I'm getting it ready for JPRT now (will do some local testing first) and will push later today.
> /Jesper
>
> On 2013-01-16 18:09, Vladimir Kozlov wrote:
>> Good.
>>
>> Vladimir
>>
>> On 1/16/13 1:49 AM, Aleksey Shipilev wrote:
>>> On 01/16/2013 01:45 PM, Staffan Larsen wrote:
>>>> Thanks for jumping on this.
>>>
>>> That's my sin to write that dumb code in the first place.
>>>
>>>> Shouldn't this be looked up the same way the other constants are looked up?
>>>> Something like:
>>>>
>>>> FIELDINFO_TAG_MASK = db.lookupIntConstant("FIELDINFO_TAG_MASK").shortValue();
>>>
>>> Yes, that occurred to me as well, see updated webrev:
>>> http://cr.openjdk.java.net/~shade/8006403/webrev.02/
>>>
>>> Tested that jstack now works fine.
>>>
>>> -Aleksey.
>>>
More information about the hotspot-dev
mailing list