Review Request (S) 8005128: JSR 292: the mlvm redefineClassInBootstrap test crashes in ConstantPool::compare_entry_to

Coleen Phillimore coleen.phillimore at oracle.com
Wed Jan 16 18:27:39 PST 2013


Serguei,

This code looks good.  Thank you for fixing this.

Co;eem


On 1/16/2013 4:46 PM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>   https://jbs.oracle.com/bugs/browse/JDK-8005128
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8005128-JVMTI-JSR292.0/ 
>
>
> Summary:
>   When constant pool is copied by the merge_constant_pools()
>   the invokedynamic operands must be copied in a right order.
>   The pool_holder needs to be set before copying the operands.
>
> Testing:
>   nsk.jvmti.testlist, nsk.jdi.testlist, nsk.jdwp.testlist,
>   vm/mlvm/indy/func/jvmti/redefineClassInBootstrap
>   Will check if any jtreg tests are useful.
>
> Thanks,
> Serguei



More information about the hotspot-dev mailing list