RFR (S): 8006413: Add utility classes for writing better multiprocess tests in jtreg

[Christian Törnqvist]

> What is benefits of this library over usual shell script?

It works on all platforms, also the code is a lot cleaner and easier to maintain.

Thanks,
Christian

-----Original Message-----
From: Dmitry Samersoff 
Sent: den 17 januari 2013 15:59
To: Christian Törnqvist
Cc: Coleen Phillimore; hotspot-dev at openjdk.java.net
Subject: Re: RFR (S): 8006413: Add utility classes for writing better multiprocess tests in jtreg

On 2013-01-17 18:10, Christian Törnqvist wrote:
> Hi Dmitry,
> 
>> 1. I'm second to Coleen. Is it possible to add more comments 
>> explaining how to use this tools.
> 
> My intention is to write a detailed guide to writing jtreg tests, 
> including the use of these (and future) utility classes.

Good.

>> 2. Is it possible to create your own exception rather than use 
>> Exceptioin class directly.
> 
> I've changed it to use RuntimeException based on feedback from other 
> people

Please create your own exception class. I would like to be able to distinguish between exceptions that comes from different parts of tests.

>> 3. Who is responsible to kill started process?
> 
> This is really a task for the jtreg framework. Honestly it doesn't 
> really do this very well right now, since the process handling in Java 
> is not good enough to deal with this. I think this is a something we 
> should look into addressing in jtreg rather than having the tests 
> worry about it.

What is benefits of this library over usual shell script?

-Dmitry


> 
> Best regards, Christian
> 
> -----Original Message----- From: Dmitry Samersoff Sent: den 17 januari 
> 2013 14:14 To: Coleen Phillimore Cc:
> hotspot-dev at openjdk.java.net Subject: Re: RFR (S): 8006413: Add 
> utility classes for writing better multiprocess tests in jtreg
> 
> Christian,
> 
> 1. I'm second to Coleen. Is it possible to add more comments 
> explaining how to use this tools.
> 
> 
> 2. Is it possible to create your own exception rather than use 
> Exceptioin class directly.
> 
> 
> 3. Who is responsible to kill started process?
> 
> -Dmitry
> 
> 
> On 2013-01-16 17:53, Coleen Phillimore wrote:
>> 
>> Christian, Can you write up (somewhere!) what these are for and how 
>> these are going to be used?  I don't understand just from this
>> code.   Does jtreg know enough to build these classfiles?   Do we
>> have to write shell scripts to refer to these? Thanks, Coleen
>> 
>> On 1/16/2013 7:34 AM, Christian Törnqvist wrote:
>>> Hi everyone,
>>> 
>>> 
>>> This RFE adds a few utility classes to make it a bit easier to write 
>>> multi-process tests in jtreg, webrev can be found at 
>>> http://cr.openjdk.java.net/~brutisso/8006413/webrev.00/
>>> 
>>> 
>>> Thanks,
>>> 
>>> Christian
> 
> 
> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, 
> Russia * Give Rabbit time, and he'll always get the answer
> 


--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer