RFR (S): 8006413: Add utility classes for writing better multiprocess tests in jtreg

[Dmitry Samersoff]

Nils,

Sorry, I don't see any pain of placing all libraries necessary to
support tests to a separate place and use it from there.

And on my opinion, jtreg workspace is a good place to add something like
testtools.jar

As the worst case, it's acceptable to sync with Stuart and keep two copy
of the same library - but not two different ones doing the same,
with different class names, exceptions and bugs.

Otherwise, if my fix contains bot hotspot and jdk parts, my tests would
have to use (and I would have to learn) two different libraries.

-Dmitry



On 2013-01-17 18:34, Nils Loodin wrote:
> On 01/17/2013 03:10 PM, Christian Törnqvist wrote:
>> Well, jtreg is not in the hotspot repo (and shouldn't be) and suddenly
>> you end up having an external dependency. I'd like to keep the tests
>> free from dependence on jtreg (along with other external resources).
>>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: Dmitry Samersoff
>> Sent: den 17 januari 2013 15:06
>> To: Christian Törnqvist
>> Cc: Stuart Marks; hotspot-dev at openjdk.java.net; Jonathan Gibbons
>> Subject: Re: RFR (S): 8006413: Add utility classes for writing better
>> multiprocess tests in jtreg
>>
>> Christian,
>>
>> On my opinion something like
>>
>> import com.oracle.jtreg.tools.*
>>
>> is less painful than maintain several independent implementations of
>> the same ideas.
>>
>> -Dmitry
>>
> 
> I fully agree with Christian here. Dmitry, you have to see the pain from
> the people who are debugging the tests here, not the one implementing.
> The thresholds for rerunning / modifying / debugging tests will be very
> very much increased when introducing such dependencies!
> 
> Regards,
> Nils Loodin


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer