RFR: 8000780 back ported Fix zero fail to build in JDK7u-dev [updated]
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Jan 18 14:00:29 PST 2013
Looks good.
Vladimir
On 1/18/13 8:37 AM, Chris Phillips @ T O wrote:
> Hi Alejandro,
>
> Have updated the webrev (just off by one line in 1 file) and built both
> normal
> hotspot and zero on x86_64 based on the hsx24 repo head:
> http://integral-portal.lgonqn.org/temp/ChrisPhi/hsx24b31-8000780-zero_20130118_webrev/
> [Also now contains updated copyrights]
>
> Cheers!
> Chris
>
> On 18/01/13 05:56 AM, Alejandro E Murillo wrote:
>>
>> Hi Chris (Phillips)
>> I just got a snapshot of hs24 and bumped the build number to b31,
>> so we can resume pushing bug fixes to it.
>> Unfortunately the patch in the webrev at [1] does not apply cleanly
>> anymore,
>> Can you guys reapply the changes to clean clone of [2] and send the
>> new webrev?
>> Then if the previous reviewers approve it, I will push that soon
>> after so it makes
>> it into next week snapshot. Apologies for the extra work
>>
>> [1]http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/
>>
>> [2] http://hg.openjdk.java.net/hsx/hsx24/hotspot
>>
>>
>>
>> Thanks
>> Alejandro
>>
>>
>> On 1/2/2013 1:02 PM, Christian Thalinger wrote:
>>> On Dec 22, 2012, at 10:15 AM, Chris Phillips @ T
>>> O<ChrisPhi at lgonqn.org> wrote:
>>>
>>>> Hi Alejandro,
>>>> Oops emails crossed in the net ...
>>>> See my latest email , I had to regenerate the webrev and patch -
>>>> This webrev s/b ok:
>>>>
>>>> Webrev:
>>>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero-hs24b29_20121222/
>>>>
>>> That looks good. -- Chris
>>>
>>>> Chris
>>>>
>>>> On 22/12/12 01:03 PM, Alejandro E Murillo wrote:
>>>>> Hi Chris,
>>>>> In that case is not necessary.
>>>>> I initially thought the webrev was against jdk7u/jdk7u-dev/hotspot
>>>>> but looks like it is against hsx/hsx24/hotspot.
>>>>> BTW, I went to check the webrev link and is unreachable, can you check
>>>>> that?
>>>>> Thanks
>>>>> Alejandro
>>>>>
>>>>> On 12/21/2012 9:53 PM, Chris Phillips @ T O wrote:
>>>>>> Hi Alejandro,
>>>>>>
>>>>>> The only change since I tested this afternoon is the change
>>>>>> for the hotspot_version. I will re-run tests if you wish but it seems
>>>>>> unnecessary.
>>>>>>
>>>>>> Cheers!
>>>>>> Chris
>>>>>>
>>>>>> On 21/12/12 07:40 PM, Alejandro E Murillo wrote:
>>>>>>> On 12/21/2012 4:34 PM, Chris Phillips @ T O wrote:
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> {Not sure if this needs a new bug or not, it definitely needs a
>>>>>>>> sponsor
>>>>>>>> - Twisti ? }
>>>>>>>>
>>>>>>>> Attached is a backport (essentially resurrection of the Permgen
>>>>>>>> code)
>>>>>>>> of 8000780 now updated with Roman Kennke's comments. Checked and
>>>>>>>> built
>>>>>>>> against hsx24b28. (Current jdk7u-dev hs)
>>>>>>>>
>>>>>>>> Please review.
>>>>>>>>
>>>>>>>> Cheers!
>>>>>>>> Chris
>>>>>>>> PS
>>>>>>>> Webrev is here:
>>>>>>>> http://integral-portal.lgonqn.org/temp/ChrisPhi/jdk7u-dev-zero/hs24b28/
>>>>>>>>
>>>>>>>>
>>>>>>> Hi
>>>>>>> jdk7u-dev/hotspot corresponds to hs24-b27.
>>>>>>> I just got the hs24 snapshot for b28 and bumped the number to b29,
>>>>>>> Can you rework the patch/webrev against this repo:
>>>>>>>
>>>>>>> http://hg.openjdk.java.net/hsx/hsx24/hotspot
>>>>>>>
>>>>>>> once it's reviewed I can push it
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>
>>
>>
>>
>
More information about the hotspot-dev
mailing list