Code review request: JDK-8000692,Remove old KERNEL code
David Holmes
david.holmes at oracle.com
Sun Jan 20 17:36:49 PST 2013
On 19/01/2013 8:06 AM, Zhengyu Gu wrote:
> On 1/18/2013 4:52 PM, Chris Plummer wrote:
>> src/share/vm/classfile/systemDictionary.cpp: I guess the removal of
>> the following code is correct. The original code was odd since it had
>> a kernel reference outside of #ifdef KERNEL, and then a non-kernel
>> reference (which you removed), within the "if". Just want to double
>> check that this is the right thing to do.
>>
>> 1826 if (init_opt == SystemDictionary::Opt_Kernel) {
>> 1827 #ifndef KERNEL
>> 1828 try_load = false;
>> 1829 #endif //KERNEL
>> 1830 }
> I removed SystemDictionary::Opt_Kernel. Can anyone verify if it is OK?
Yes. Also note that the try_load flag is now always true and so can be
removed.
David
More information about the hotspot-dev
mailing list