Review request: JDK-8004147 test/Makefile jtreg_tests target does not work with cygwin

Mikael Gerdin mikael.gerdin at oracle.com
Tue Jan 22 04:39:47 PST 2013


Christian,

On 2013-01-22 13:06, Christian Törnqvist wrote:
> Hi Mikael,
>
> Might not be in scope for this change, but we should add '-retain:fail,error' to the jtreg command line, otherwise it'll only save the artifacts (including hs_err and core files) from the last executed test with status fail/error.

I agree that '-retain:fail,error' would be useful but since this 
particular functionality is not used by regular JPRT runs I'd rather do 
that as a separate fix, perhaps when/if we decide to start running jtreg 
tests in normal JPRT runs.

/Mikael

>
> Otherwise it looks good :)
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: Mikael Gerdin
> Sent: den 21 januari 2013 12:34
> To: hotspot-dev developers
> Subject: Review request: JDK-8004147 test/Makefile jtreg_tests target does not work with cygwin
>
> Hi,
>
> When trying to run the hotspot regression tests with cygwin I noticed that the paths passed to the jtreg launcher suffers from the same issue as was found in JDK-7152791.
>
> My suggested fix is to convert the paths before passing them to the jtreg launcher.
>
> Webrev: http://cr.openjdk.java.net/~mgerdin/8004147/webrev.0/
>
>
>
> --
> Mikael Gerdin
> Java SE VM SQE Stockholm
>

-- 
Mikael Gerdin
Java SE VM SQE Stockholm


More information about the hotspot-dev mailing list