Code review request: JDK-8000692,Remove old KERNEL code

Zhengyu Gu zhengyu.gu at oracle.com
Tue Jan 22 06:45:05 PST 2013


Hi David,

Calvin also pointed this out, and checked JDK repo, he said there is no 
reference to this field. However, I think jvm_version_info is an 
exported structure, we can not simply remove it. My impression is  that 
we have to update spec and depreciate it before we can safely remove it, 
but I am not sure.

Can anyone point me the right process for removing the field?  should I 
file a JBS bug and CCC request?

Thanks,

-Zhengyu



On 1/20/2013 8:54 PM, David Holmes wrote:
> Hi Zhengyu,
>
> In addition to comments already made:
>
> src/share/vm/prims/jvm.cpp
>
>  info->is_kernel_jvm = 0; // false;
>
> Does this imply we need to update the spec and definition of 
> jvm_version_info?
>
> And are there further changes needed on the JDK side? Where is/was the 
> jkernel download manager class?
>
> Thanks,
> David
>
> On 19/01/2013 4:22 AM, Zhengyu Gu wrote:
>> Hi,
>>
>> This is a cleanup of kernel code, since it is already obsoleted - JDK7
>> and JDK8 are no longer building kernel.
>>
>> JBS: https://jbs.oracle.com/bugs/browse/JDK-8000692
>> Webrev: http://cr.openjdk.java.net/~zgu/8000692/webrev.00/
>>
>> Tests:
>> - JPRT
>> - ute vm.quick.testlist on Linux x32.
>>
>> Thanks,
>>
>> -Zhengyu


More information about the hotspot-dev mailing list