Request for review (XS): JDK-8006758: LinkResolver assertion (caused by @Contended changes)

[Aleksey Shipilev]

On 01/24/2013 01:18 PM, Krystal Mo wrote:
> But the JSR 292 annotations, at least @Compiled, are mandatory
> annotations used for core functionalities. Silently noop-ing them can be
> disastrous, as we've seen in this bug.

That's right, and we need to hear John's opinion on this, because it was
his original idea to booby trap these annotations along with the JSR292
annotations. Which, I presume, was considered as the potentially
breaking change, but given the VM annotations are injected from the VM
code it was presumed the assert would not actually fire anyway? (Which
again was proven wrong in this incident).

> Maybe we should add an assertion when a @Compiled is found on
> unprivileged code, to catch the problem right there.

That's a good idea. Debug builds should be failing with understandable
asserts.

-Aleksey.