Request for review (XS): JDK-8006758: LinkResolver assertion (caused by @Contended changes)

Aleksey Shipilev aleksey.shipilev at oracle.com
Thu Jan 24 01:47:01 PST 2013


On 01/24/2013 01:33 PM, David Holmes wrote:
>>> My concern is whether this whole "privileged" notion that @Contended
>>> introduced is actually valid? Is this how the constraint that @Contended
>>> can only be applied to classes on the bootclasspath was implemented?
>> The current consensus is that sun.misc.* members should be
>> unaccessible/noop-ed for unprivileged classes. This applies as the
>> general rule, and some annotations can have the exception with the VM
>> flag (-XX:-RestrictContended in this case).
> 
> It's not the policy I was questioning but the implementation. Given all
> the different notions of "privilege" that already exist this seems
> somewhat adhoc and slightly crude. But that is with hindsight.

Oh yes, I can relate to this. However, this was viewed by most of the
reviewers as appropriate idiomatic form for VM code.

-Aleksey.



More information about the hotspot-dev mailing list