Request for review (XS): JDK-8006758: LinkResolver assertion (caused by @Contended changes)

[Krystal Mo]

Coleen,

Thank you for the review. I listed you as a reviewer :-)
I have pushed it to hotspot-comp already indeed, and I'm just about to 
sync hotspot-comp to hotspot-main.

Thanks,
Kris

On 01/24/2013 10:09 PM, Coleen Phillimore wrote:
>
> This change looks good to me also.    Hopefully you've already pushed it.
>
> On 1/24/2013 3:53 AM, David Holmes wrote:
>> Hi Kris,
>>
>> On 24/01/2013 6:06 PM, Krystal Mo wrote:
>>> Hi all,
>>>
>>> Could anyone review this patch, please?
>>
>> Based on your description this patch seems to address the immediate 
>> problem.
>>
>> My concern is whether this whole "privileged" notion that @Contended 
>> introduced is actually valid? Is this how the constraint that 
>> @Contended can only be applied to classes on the bootclasspath was 
>> implemented?
>>
>> I'd also like to know what tests needed to be run to catch this. 
>> Maybe we need to add some jsr292 tests to JPRT?
>
> Yes and some SA tests too, since it's very easy to break the SA (rest 
> of comment deleted).
>
> Coleen