Request for review (XS): JDK-8006758: LinkResolver assertion (caused by @Contended changes)

[Krystal Mo]

On 01/24/2013 11:19 PM, Alejandro E Murillo wrote:
>
> Sounds good Kris,
> please make sure this is indeed fixing the failures showing in nightly 
> before you push to hs-main,
> not asking to wait for nightly, but to run those failing tests
Thanks for the reminder, Alejandro.
I have done so. The jtreg tests in compiler and java/lang/invoke that 
failed due to this bug now pass.

Thanks,
Kris

> cheers
> Alejandro
>
> On 1/24/2013 8:04 AM, Krystal Mo wrote:
>> Coleen,
>>
>> Thank you for the review. I listed you as a reviewer :-)
>> I have pushed it to hotspot-comp already indeed, and I'm just about 
>> to sync hotspot-comp to hotspot-main.
>>
>> Thanks,
>> Kris
>>
>> On 01/24/2013 10:09 PM, Coleen Phillimore wrote:
>>>
>>> This change looks good to me also.    Hopefully you've already 
>>> pushed it.
>>>
>>> On 1/24/2013 3:53 AM, David Holmes wrote:
>>>> Hi Kris,
>>>>
>>>> On 24/01/2013 6:06 PM, Krystal Mo wrote:
>>>>> Hi all,
>>>>>
>>>>> Could anyone review this patch, please?
>>>>
>>>> Based on your description this patch seems to address the immediate 
>>>> problem.
>>>>
>>>> My concern is whether this whole "privileged" notion that 
>>>> @Contended introduced is actually valid? Is this how the constraint 
>>>> that @Contended can only be applied to classes on the bootclasspath 
>>>> was implemented?
>>>>
>>>> I'd also like to know what tests needed to be run to catch this. 
>>>> Maybe we need to add some jsr292 tests to JPRT?
>>>
>>> Yes and some SA tests too, since it's very easy to break the SA 
>>> (rest of comment deleted).
>>>
>>> Coleen