Review request for JDK-8006949: Update hotspot for MethodParameters format change

Coleen Phillimore coleen.phillimore at oracle.com
Mon Jan 28 13:47:17 PST 2013


This is nice change to have the flags smaller.  The method parameter 
tests are disabled and method parameters aren't found in the JDK 
classfiles yet, so this will not fail with a version of the JDK that has 
the flags as u4, right?

Thanks,
Coleen

On 01/28/2013 02:42 PM, Eric McCorkle wrote:
> Hello,
>
> Please review this patch, which updates hotspot in accordance with
> changes to the class file format of MethodParameters attributes.
>
> The latest spec version is here:
> http://cr.openjdk.java.net/~abuckley/8misc.pdf
>
> Any questions regarding the format change or the spec should be directed
> to Alex Buckley, the spec owner.
>
> The webrev is here:
> http://cr.openjdk.java.net/~emc/8006949/
>
> The enhancement request is here:
> http://bugs.sun.com/view_bug.do?bug_id=8006949
>
> The following CCC has been filed for this change:
> http://ccc.us.oracle.com/8006948
>
>
> The end-to-end tests for MethodParameters are presently disabled;
> however, I have run the end-to-end tests with this patch, as well as the
> companion patch for JDK-8006948, and seen no failures.
>
> I am presently running testlist and JPRT jobs; however, given the
> extremely small nature of the changeset, I do not anticipate seeing any
> failures.
>
> Thanks,
> Eric



More information about the hotspot-dev mailing list