Request for review: JDK-8003581, , UseG1GC is not properly accounted for by INCLUDE_ALTERNATE_GCS

[David Holmes]

Hi Joe,

I think you could simplify this further by deleting lines 3168 - 3186 
and change force_serial_gc() to do:

  static void force_serial_gc() {
    FLAG_SET_DEFAULT(UseSerialGC, true);
    UNSUPPORTED_GC_OPTION(UseG1GC);
    UNSUPPORTED_GC_OPTION(UseParallelGC);
    UNSUPPORTED_GC_OPTION(UseParallelOldGC);
    UNSUPPORTED_GC_OPTION(UseConcMarkSweepGC);
    UNSUPPORTED_GC_OPTION(UseParNewGC);
    FLAG_SET_DEFAULT(CMSIncrementalMode, false);  // special CMS suboption
  }

and then:

3221 #if (!INCLUDE_ALL_GCS || defined JAVASE_EMBEDDED || defined ARM)
3222   force_serial_gc();
3223 #endif

Assuming only serialGC is available on embedded or ARM.

David
-----

On 26/01/2013 2:25 AM, Joe Provino wrote:
> With changes from Bob and David, here is a new webrev:
>
> http://cr.openjdk.java.net/~jprovino/8003581/webrev.01
>
> joe
>
> On 1/25/2013 12:44 AM, David Holmes wrote:
>> On 25/01/2013 4:45 AM, Bob Vandette wrote:
>>> You claim to be defaulting to SerialGC but you don't set UseG1GC to
>>> false?
>>
>> The UNSUPPORTED_OPTION macro does that.
>>
>> But I don't see anything forcing use of serialGC. And
>> force_serial_gc() should not be altered.
>>
>>> If you build with INCLUDE_ALL_GCS=1, the G1 code will be available
>>> and be used.
>>
>> Only on those platforms that support it.
>>
>> David
>>
>>> Bob.
>>>
>>> On Jan 24, 2013, at 1:38 PM, Joe Provino wrote:
>>>
>>>> Webrev is here: http://cr.openjdk.java.net/~jprovino/8003581/webrev.00
>>>>
>>>> It's a change to one file: arguments.cpp.
>>>>
>>>> thanks.
>>>>
>>>> joe
>>>