RFR(XXS): 8019382 : PPC64: Fix bytecodeInterpreter to compile with '-Wunused-value'
Vladimir Kozlov
vladimir.kozlov at oracle.com
Mon Jul 1 14:12:52 PDT 2013
Reviewed.
I am pushing this into comp repo with me and Coleen as reviewers.
Thanks,
Vladimir
On 7/1/13 1:59 PM, Coleen Phillimore wrote:
>
> Looks good. If you need someone to check it, I'll do it after you get
> another review.
> Coleen
>
> On 07/01/2013 12:28 PM, Volker Simonis wrote:
>> Hi,
>>
>> this is a patch from the PowerPC/AIX porting project but it only
>> changes shared code and it fixes a build problem in the C++
>> interpreter which also affects the Zero-Port so I would strongly
>> recommend to push it right into the hotspot repository.
>>
>> The problem is related to "8014431 : cleanup warnings indicated by the
>> -Wunused-value compiler option on linux" which added the
>> "-Wunused-value" option to the Linux build but did not clean up the
>> code in the c++ interpreter. This lead to several warnings which are
>> now treated as errors when compiling bytecodeInterpreter.cpp.
>>
>> The fix is easy - just cast the offending expressions to void:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8019382/
>>
>> Thank you and best regards,
>> Volker
>
More information about the hotspot-dev
mailing list