Request for review: https://jbs.oracle.com/bugs/browse/JDK-8017473

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Jul 3 12:27:54 PDT 2013


I don't like to have renaming done together with the fix. Is renaming 
required?

Thanks,
Vladimir

On 7/3/13 12:10 PM, Joseph Provino wrote:
> Bug report: https://jbs.oracle.com/bugs/browse/JDK-8017473
>
> This is for SE_8 but will be backported to 7u.
>
> Webrev: http://cr.openjdk.java.net/~jprovino/8017473/webrev.00/
> <http://cr.openjdk.java.net/%7Ejprovino/8017473/webrev.00/>
>
> I changed PLATFORM_NMT_DETAIL_SUPPORTED to
> PLATFORM_NATIVE_STACK_WALKING_SUPPORTED
> to make the name more general.
>
> Added -DPLATFORM_NMT_DETAIL_SUPPORTED=1 to linux/makefiles/debug.make
> because
> with the low optimization for debug builds, -fno-omit-frame-pointer is
> set and stack walking
> is always permissible.
>
> Changed vm.make to optionally include an architecture specific makefile
> in case some files
> need to be compiled with special options such as -fno-omit-frame-pointer.
>
> Thanks.
>
> joe


More information about the hotspot-dev mailing list