Request for review: https://jbs.oracle.com/bugs/browse/JDK-8017473

[Vladimir Kozlov]

Thank you for explaining situation, it was confusing.

Since you are going to backport it into 7u40 the fix should be simple 
and targeted. For me the suggestion to use new 
PLATFORM_NATIVE_STACK_WALKING_SUPPORTED to fix this 8017473.

As you said NMT is nothing to do with this. So using 
PLATFORM_NATIVE_STACK_WALKING_SUPPORTED instead of 
PLATFORM_NMT_DETAIL_SUPPORTED is also questionable.

Why you use "PLATFORM_" prefix in names?

Thanks,
Vladimir

On 7/3/13 12:53 PM, Joseph Provino wrote:
> On 07/03/2013 03:27 PM, Vladimir Kozlov wrote:
>> I don't like to have renaming done together with the fix. Is renaming
>> required?
>>
>> Thanks,
>> Vladimir
>
> Renaming isn't required but if I keep PLATFORM_NMT_DETAIL_SUPPORTED
> I would need to add the new flag PLATFORM_NATIVE_STACK_WALKING_SUPPORTED.
>
> I could use PLATFORM_NMT_DETAIL_SUPPORTED but NMT doesn't have anything
> to do
> with this bug 8017473.
>
> What happened is that 8011064 got reported and fixed first.  The fix was
> to disallow
> NMT_detail in some cases so PLATFORM_NMT_DETAIL_SUPPORTED made sense.
>
> Bug 8017473 makes it clear that there are times when native stack
> walking can't be done.
> PLATFORM_NATIVE_STACK_WALKING_SUPPORTED is more general and makes sense for
> 8011064 and 8017473.
>
> Do you think it would be better to use a new name and then file another
> bug to change
> PLATFORM_NMT_DETAIL_SUPPORTED to PLATFORM_NATIVE_STACK_WALKING_SUPPORTED?
>
> joe
>
>>
>> On 7/3/13 12:10 PM, Joseph Provino wrote:
>>> Bug report: https://jbs.oracle.com/bugs/browse/JDK-8017473
>>>
>>> This is for SE_8 but will be backported to 7u.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jprovino/8017473/webrev.00/
>>> <http://cr.openjdk.java.net/%7Ejprovino/8017473/webrev.00/>
>>>
>>> I changed PLATFORM_NMT_DETAIL_SUPPORTED to
>>> PLATFORM_NATIVE_STACK_WALKING_SUPPORTED
>>> to make the name more general.
>>>
>>> Added -DPLATFORM_NMT_DETAIL_SUPPORTED=1 to linux/makefiles/debug.make
>>> because
>>> with the low optimization for debug builds, -fno-omit-frame-pointer is
>>> set and stack walking
>>> is always permissible.
>>>
>>> Changed vm.make to optionally include an architecture specific makefile
>>> in case some files
>>> need to be compiled with special options such as
>>> -fno-omit-frame-pointer.
>>>
>>> Thanks.
>>>
>>> joe
>