7u40 RFR: 8012144 - Missing memory barriers
Aleksey Shipilev
aleksey.shipilev at oracle.com
Wed Jul 10 05:36:15 PDT 2013
On 07/10/2013 05:07 AM, David Holmes wrote:
> On 9/07/2013 7:01 PM, Lindenmaier, Goetz wrote:
>> Actually, I would use X86 instead of IA32 || AMD64.
>> (maybe add #include utilities/macros.hpp, but X86 is
>> defined before all uses of taskqueue.hpp. I tested this
>> on linux.)
>
> Unfortunately I don't have time to make this change and re-do the
> testing that has already been done.
Actually, there is a few uses like that already. Hence, it makes little
sense to fix this nit in current patch, but rather, do the rehash of
IA32||AMD64 -> X86 macro separately.
$ ack-grep -Q "defined(IA32) || defined(AMD64)" hotspot/src/
hotspot/src/share/vm/adlc/output_c.cpp
2294:#if defined(IA32) || defined(AMD64)
hotspot/src/share/vm/opto/machnode.hpp
97:#if defined(IA32) || defined(AMD64)
hotspot/src/share/vm/utilities/macros.hpp
305:#if defined(IA32) || defined(AMD64)
hotspot/src/share/vm/interpreter/interpreterRuntime.hpp
139:#if defined(IA32) || defined(AMD64) || defined(ARM)
hotspot/src/share/vm/interpreter/interpreterRuntime.cpp
1193:#if defined(IA32) || defined(AMD64) || defined(ARM)
hotspot/src/os/windows/vm/os_windows.cpp
2989:#if defined(IA32) || defined(AMD64)
3000:#if defined(IA32) || defined(AMD64)
hotspot/src/os/linux/vm/os_linux.cpp
1412:#if defined(IA32) || defined(AMD64)
-Aleksey.
More information about the hotspot-dev
mailing list