RFR (XL): 8019972: PPC64 (part 9): platform files for interpreter only VM.

[Volker Simonis]

On Wed, Jul 17, 2013 at 8:38 PM, Vladimir Kozlov
<vladimir.kozlov at oracle.com> wrote:
> On 7/17/13 10:18 AM, Christian Thalinger wrote:
>>
>> One question:  why did you choose to prefix all assembler instructions
>> with ppc_?
>

I agree that the 'ppc_' prefix is somewhat redundant but it has always
always been like this:) and it really helps if you are using cscope
(or plain grep).

Also IDEs like Eclipse and NetBeans don't handle several functions
with the same name (and signature) very well (actually, the navigation
isn't working at all in such circumstances).

Is this really a show-stopper? Changing this would mean that we would
have to change all our internal sources which is quite an effort.

Thank you and best regards,
Volker

>
> +1
>
> and PPC_ prefix in registers names.
>
> Goetz, it is different from our naming style so we would really appreciate
> if you change this.
>
> Regards,
> Vladimir
>
>
>>
>> -- Chris
>>
>> On Jul 17, 2013, at 8:34 AM, "Lindenmaier, Goetz"
>> <goetz.lindenmaier at sap.com> wrote:
>>
>>> Hi,
>>>
>>> This time with webrev. Sorry for the double mails.
>>>
>>> This change contains all the files in cpu/ppc and os_cpu/linux_ppc needed
>>> for
>>> the PPC64 interpreter port on linux.
>>>
>>> With this change you can do a core build on ppc64 and run the VM
>>> interpreter only.
>>> It executes simple programs as jvm98.
>>> The change requires
>>>
>>> *         8016697: Use stubs to implement safefetch
>>>
>>> *         8020059: The flag introduced by 8014972 is not defined ...
>>> which will arrive soon in the staging repository.
>>>
>>> I marked the change as XL as it contains a lot of code.  Nevertheless the
>>> code has no impact on the existing Oracle platforms.
>>>
>>> The change touches a single shared file, globals.hpp, removing a
>>> special case introduced for the port.  This is because we
>>> integrated some changes earlier than originally intended.
>>>
>>> Please review the change.  Does it need testing on Oracle side?
>>> http://cr.openjdk.java.net/~goetz/webrevs/8019972-ppc_files/
>>>
>>> Best regards,
>>>   Goetz.
>>>
>>
>