RFR: 8021314 minimal1.make needs to force off components not supported by the minimal VM

Coleen Phillmore coleen.phillimore at oracle.com
Thu Jul 25 17:16:12 PDT 2013


Looks good to me.
Coleen

On 7/25/2013 7:48 PM, David Holmes wrote:
> On 26/07/2013 12:33 AM, BILL PITTORE wrote:
>> Not an official reviewer but I like it.
>
> Thanks Bill.
>
> Still need a Reviewer.
>
> David
>
>> bill
>>
>> On 7/25/2013 3:02 AM, David Holmes wrote:
>>> webrev: http://cr.openjdk.java.net/~dholmes/8021314/webrev/
>>>
>>> A simple fix. Where we used ?= to only set an INCLUDE_* variable to
>>> false if not already set, we really want to set it to false
>>> regardless. You can still pass the variable as make arg to bypass this
>>> logic if you know what you are doing, but we don't want to other parts
>>> of the build to enable variables that the minimal VM doesn't support.
>>>
>>> Thanks,
>>> David
>>>
>>
>>



More information about the hotspot-dev mailing list