RFR(XS): 8016105: Add complementary RETURN_NULL allocation macros in allocation.hpp
Rickard Bäckman
rickard.backman at oracle.com
Wed Jun 12 02:32:04 PDT 2013
Looks good to me.
/R
On Jun 10, 2013, at 11:46 AM, Markus Grönlund wrote:
> Updated webrev with REALLOC_C_HEAP_ARRAY2 removed:
>
> http://cr.openjdk.java.net/~mgronlun/8016105/webrev02/
>
>
> Thanks to reviewing
>
> Markus
>
> -----Original Message-----
> From: Markus Grönlund
> Sent: den 10 juni 2013 11:15
> To: Staffan Larsen
> Cc: hotspot-dev at openjdk.java.net Developers
> Subject: RE: RFR(XS): 8016105: Add complementary RETURN_NULL allocation macros in allocation.hpp
>
> Thanks Staffan,
>
> Thanks for spotting - it can be removed.
>
> Thanks
> Markus
>
> -----Original Message-----
> From: Staffan Larsen
> Sent: den 10 juni 2013 11:06
> To: Markus Grönlund
> Cc: hotspot-dev at openjdk.java.net Developers
> Subject: Re: RFR(XS): 8016105: Add complementary RETURN_NULL allocation macros in allocation.hpp
>
> Looks good, but do we need REALLOC_C_HEAP_ARRAY2()? It is never used and does not seem to add anything compared to REALLOC_C_HEAP_ARRAY / REALLOC_C_HEAP_ARRAY_RETURN_NULL.
>
> /Staffan
>
> On 7 jun 2013, at 09:07, Markus Grönlund <markus.gronlund at oracle.com> wrote:
>
>> Greetings,
>>
>>
>>
>> Kindly asking for reviews for the following:
>>
>>
>>
>> Bug id: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016105
>>
>>
>>
>> Webrev: http://cr.openjdk.java.net/~mgronlun/8016105/webrev01/
>>
>>
>>
>>
>>
>> Thank you
>>
>> Markus
>
More information about the hotspot-dev
mailing list