hg: hsx/hsx24/hotspot: 2 new changesets

[Erik Helin]

Hi Volker,

On 2013-06-14, Volker Simonis wrote:
> Hi Erik,
> 
> could you please explain how it could happen that this change has been
> pushed two times?

it looks like I pushed this change twice. There is nothing preventing us
from pushing the same change twice and I must have made a mistake. In
most cases, the merge that mercurial automatically does would not be
successful. However, in this case the second merge, changeset
cea88a661227, unfortunately succeeds even though the first push has
already been done.

Thanks for finding this!

On 2013-06-14, Volker Simonis wrote:
> http://hg.openjdk.java.net/hsx/hsx24/hotspot/log?rev=8011891
> 
> It seems that, even if not wrong, the code is now at least not optimal,
> because save_heap_summary() will now be called two times.

You are correct. The extra call to save_heap_summary will not cause any
correctness problems but will, of course, make CMS slower.

I will create a patch and send it out for review on
hotspot-gc-dev at openjdk.java.net that removes the extra, unnecessary, if
statement.

Again, thank you for finding this!

Erik

> Thank you and best regards,
> Volker
> 
> 
> Changeset: c78ea7137c06
> Author:    ehelin
> Date:      2013-05-17 15:28 +0200
> URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/c78ea7137c06
> 
> 8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old
> data
> Reviewed-by: brutisso, stefank
> 
> !
> src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
> 
> Changeset: 3e38b7096830
> Author:    ehelin
> Date:      2013-05-20 14:18 +0200
> URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/3e38b7096830
> 
> Merge
> 
> !
> src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
> 
> 
> On Tue, May 21, 2013 at 11:05 PM, <erik.helin at oracle.com> wrote:
> 
> > Changeset: 97eb1ea6bae8
> > Author:    ehelin
> > Date:      2013-05-21 20:29 +0200
> > URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/97eb1ea6bae8
> >
> > 8011891: The vm/gc/heap/heap_summary_after_gc event for CMS contains old
> > data
> > Reviewed-by: brutisso, stefank
> >
> > !
> > src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp
> >
> > Changeset: cea88a661227
> > Author:    ehelin
> > Date:      2013-05-21 20:46 +0200
> > URL:       http://hg.openjdk.java.net/hsx/hsx24/hotspot/rev/cea88a661227
> >
> > Merge
> >
> >
> >