RFR(S): 8017313: PPC64 (part 6): cppInterpreter: stack handling improvements
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Jun 25 05:49:22 PDT 2013
Which stack limit is this? Does it subtract off the red and yellow
zones? Where do you set it? Yes, it would simplify the assembler code
in the interpreter entries to use this.
It might be better to rename it though if it's the usable stack
(subtracting red and yellow zones) and maybe compute the value inside of
Thread class (so you see it always subtracting the red and yellow
zones). It's sort of ambiguous that this is happening. How about
stack_overflow_limit()?
Thanks,
Coleen
On 06/25/2013 08:44 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> We precompute the stack limit for overflow checks and save this
> limit in the thread. This simplifies the assembler coding checking
> the stack overflow. This change contains the necessary shared
> functionality. It can easily be ported to other platforms, too.
> http://cr.openjdk.java.net/~goetz/webrevs/8017313-stack/
>
> Please review this change.
>
> Best regards,
> Goetz.
>
> PS: I removed some parts of patch 0006 because I found a better
> platform-only solution.
More information about the hotspot-dev
mailing list