Request for review: 8017611: Auto corrector for mistyped vm options

Bengt Rutisson bengt.rutisson at oracle.com
Tue Jun 25 22:05:42 PDT 2013


Tao,

This is great! Thanks for doing this! :)

I haven't looked closely at the code yet, so this is not a review, but I 
agree with Christian that we don't need a flag for the "fuzziness". 
Also, it seems like it would be pretty straight forward to write a 
couple of tests for this feature. Maybe just two simple JTreg tests, one 
that tests that a misspelled command line option gets the right 
suggestion and one correctly spelled option that does not cause a 
suggestion.

Thanks again for coming up with this!
Bengt



On 6/25/13 8:33 PM, Tao Mao wrote:
> OK, I'll move the flag to be local.
>
> Thanks.
> Tao
>
> On 6/25/13 11:13 AM, Vladimir Kozlov wrote:
>> Yes we need this! How many times I mistyped PrintMiscellaneous :( ?
>>
>> Why we need additional flag VMOptionsFuzzyMatchSimilarity (we have 
>> too many already)? Can you use a local constant?
>>
>> Where is whole Christian's mail?
>>
>> I redirected this RFR to hotspot-dev since it affects everyone.
>>
>> thanks,
>> Vladimir
>>
>> On 6/25/13 11:01 AM, Tao Mao wrote:
>>> Hi Chris,
>>>
>>> So you suggest the flag be "notproduct" or "develop"?
>>>
>>> Thanks.
>>> Tao
>>>
>>> On 6/25/13 10:59 AM, Christian Thalinger wrote:
>>>> I think we can do one step further to interpret the user's intent and
>>>> suggest the correct VM options. Then i start to imagine that we have
>>>> something like this



More information about the hotspot-dev mailing list