RFR: JDK-8009152 - A number of jtreg tests need review/improvement
Alan Bateman
Alan.Bateman at oracle.com
Thu Mar 7 02:16:24 PST 2013
On 07/03/2013 00:43, Gary Collins wrote:
> Request for Review
>
> Changes to allow better test utilization of jtreg hotspot regression tests
> 1: REPLACED JAVA_HOME with TESTJAVA
> 2: REPLACED TESTJAVA with COMPILEJAVA Some tests needed tools like (javac,jar,path to native libraries) to run.
> NOTE: THIS IS NEEDED WHEN TESTJAVA is a JRE. If TESTJAVA is a JDK then COMPILEJAVA is not needed.
> NOTE: FALLBACK when COMPILEJAVA is not defined for JTREG is TESTJAVA (with implied JDK being tested)
You are only getting this fallback when running the shell tests via
jtreg. I don't know if it common for people to run the tests directly
but if it is then the scripts will need to check if COMPILEJAVA is set
and if not, set it to ${TESTJAVA}. I suggest this as otherwise it will
be cumbersome to run the tests directly. Also the tests fail if TESTJAVA
is set and they don't seem to fail if COMPILEJAVA is not set (at least
for the few tests that I looked at in the webrev).
-Alan.
More information about the hotspot-dev
mailing list