RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

[Vladimir Kozlov]

Why do you need a switch in next code in 
LibraryCallKit::inline_native_Reflection_getCallerClass()?
I don't think you need to match JVM_GetCallerClass code one-to-one. You 
don't have =0 case and the check for =1 could be done before loop. It 
will simplify code.

Adjust next comment to reference JVM_GetCallerClass:

// Frame 0 and 1 must be caller sensitive (see JVM_GetCallerClass)


I think in JVM_GetCallerClass() you can use intrinsic_id:

m->intrinsic_id() == vmIntrinsics::_getCallerClass

Thanks,
Vladimir

On 3/14/13 8:31 PM, Christian Thalinger wrote:
> [This is the HotSpot part of JEP 176]
>
> http://cr.openjdk.java.net/~twisti/7198429
>
> 7198429: need checked categorization of caller-sensitive methods in the JDK
> Reviewed-by:
>
> More information in JEP 176:
>
> http://openjdk.java.net/jeps/176
>
> src/share/vm/ci/ciMethod.cpp
> src/share/vm/ci/ciMethod.hpp
> src/share/vm/classfile/classFileParser.cpp
> src/share/vm/classfile/classFileParser.hpp
> src/share/vm/classfile/javaClasses.hpp
> src/share/vm/classfile/systemDictionary.hpp
> src/share/vm/classfile/vmSymbols.hpp
> src/share/vm/oops/method.cpp
> src/share/vm/oops/method.hpp
> src/share/vm/opto/library_call.cpp
> src/share/vm/prims/jvm.cpp
> src/share/vm/prims/methodHandles.cpp
> src/share/vm/prims/unsafe.cpp
> src/share/vm/runtime/vframe.cpp
> src/share/vm/runtime/vframe.hpp
>