RFR 8009382: Add JVM_Get{Field|Method}TypeAnnotations

Christian Thalinger christian.thalinger at oracle.com
Fri Mar 22 10:27:23 PDT 2013


On Mar 22, 2013, at 7:16 AM, Joel Borggrén-Franck <joel.franck at oracle.com> wrote:

> Hi,
> 
> Please review: http://cr.openjdk.java.net/~jfranck/8009382/hotspot/webrev.01/
> 
> Bug is here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009382
> 
> In short, this is needed in order to implement the desired semantics for reflecting over type annotations after a class redefine. This is also needed in order to reduce the size overhead introduces on the JDK side in the current type annotations reflection implementation.
> 
> A prototype of the jdk changes can be found here: http://cr.openjdk.java.net/~jfranck/8009382/jdk/webrev.00/

Can we not called them foo0?  That trailing 0 doesn't give any value.

-- Chris

> 
> While in the neighborhood I also fixed a handful of unlikely but possible null dereferences and removed an unused resource mark. I have run jdk_lang on a fastdebug build to verify the removal of the resource mark in addition to manual verification (also Dan helped me look into this, but errors are mine).
> 
> For Oracle reviewers, ccc is approved.
> 
> testing done:
> 
> jdk_lang with and without my prototype jdk changes x product/fastdebug
> vm.quick.testlist
> jprt standard build and test
> 
> cheers
> /Joel



More information about the hotspot-dev mailing list