Request for review (S): JDK-8011009: Use do-while(0) instead of while(0) in EC_TRACE and RC_TRACE* macros
Krystal Mo
krystal.mo at oracle.com
Thu Mar 28 15:11:37 PDT 2013
Hi all,
Could I have a review for this small patch, please?
Webrev: http://cr.openjdk.java.net/~kmo/8011009/webrev.00
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011009
This patch improves the EC_TRACE and RC_TRACE* family of macros to be
less error prone.
They used to end with while(0) to make the macros statement-like, but a
better way to do this is do {...} while(0).
Testing with JPRT, will send an update email when it's done.
P.S. I'm not sure where I should send this email for review, should it
be hotspot-runtime or serviceability?
Thanks,
Kris
More information about the hotspot-dev
mailing list